[JENKINS-46124] - support map with EnvStep #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jetersen @dwnusbaum I hope this has been the right approach, but I would really like to see the changes from #105 merged and released 🙏. |
Author
|
@jglick @dwnusbaum @basil is anyone able to review this change please? |
Member
|
Well, I can put it on my backlog, but my backlog is pretty long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JENKINS-46124
Revival of #105 by @jetersen.
I forked jetersen:fix/JENKINS-46124 and merged the latest from jenkinsci:master.
I also completed the outstanding request to update the help text for the
withEnvstep and itsoverridesargument to mention the new map syntax.Testing done
See
mapArguments()andmapArgumentsAsMap()tests added in the original PR.Submitter checklist